[DI] [Controller] Add controller redirect response code configuration option #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robfrawley
added
Level: New Feature 🆕
Signed-off-by: Rob Frawley 2nd <rmf@src.run>
…ructor arguments are removed Signed-off-by: Rob Frawley 2nd <rmf@src.run>
|
since default branch was changed to |
dbu
approved these changes
Aug 22, 2019
|
This can be closed, #1220 has been merged |
|
wrapped up in #1220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.0This PR re-adds the
liip_imagine.controller.redirect_response_codeconfiguration option originally merged into1.0(as #970) but never merged into2.0.Introduces a new
Liip\ImagineBundle\Config\Controller\ControllerConfigservice that is passed as the forth argument toLiip\ImagineBundle\Controller\ImagineController. Not passing an instance of the newControllerConfigobject will now throw a deprecation message and the ability to not do so will be removed in3.0.The
ControllerConfigobject will also reject non-redirect HTTP codes; the configured code must be one of201,301,302,303,307, or308(otherwise an invalid argument exception will be thrown).See #1011 (comment) and its following conversation for more context on the missing PRs from
2.0that were already merged into1.x.