Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0][tests] increase code coverage by tests. #290

Merged
merged 1 commit into from
Jan 3, 2014
Merged

[1.0][tests] increase code coverage by tests. #290

merged 1 commit into from
Jan 3, 2014

Conversation

makasim
Copy link
Collaborator

@makasim makasim commented Dec 21, 2013

No description provided.

havvg
havvg reviewed Dec 22, 2013
View reviewed changes
Tests/Templating/ImagineExtensionTest.php
{
return $this->getMock('Liip\ImagineBundle\Imagine\Cache\CacheManager', array(), array(), '', false);
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new line missing

@havvg
Copy link
Contributor

havvg commented Dec 22, 2013

The tests are failing.

Could you please add the @covers annotations to the tests?

@makasim
Copy link
Collaborator Author

makasim commented Dec 23, 2013

Could you please add the @Covers annotations to the tests?

I believe cover tool itself can recoginze which class\method was covered by test.

@makasim
Copy link
Collaborator Author

makasim commented Dec 23, 2013

it is weird but travis(composer?) does not download the latest version of event dispatcher. So it fails. I think we have to wait for sometime

@makasim
Copy link
Collaborator Author

makasim commented Dec 23, 2013

@havvg tests have to pass now, could you please restart travis?

@lsmith77
Copy link
Contributor

travis will run again on a new push automatically.

@makasim
Copy link
Collaborator Author

makasim commented Dec 24, 2013

@havvg squashed&rebased tests pass

@havvg
Copy link
Contributor

havvg commented Dec 27, 2013

I believe cover tool itself can recoginze which class\method was covered by test.

Please add the @covers annotations. They are set to limit sampling of code coverage to the specified classes or methods while running the test annotated.

@makasim
Copy link
Collaborator Author

makasim commented Jan 2, 2014

@havvg done

havvg added a commit that referenced this pull request Jan 3, 2014
@havvg
Merge pull request #290 from formapro-forks/helere-tests
0b5200a 
[1.0][tests] increase code coverage by tests.
@havvg havvg merged commit 0b5200a into liip:develop Jan 3, 2014
@makasim makasim deleted the helere-tests branch January 3, 2014 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@makasim @havvg @lsmith77