added proxy cache resolver #318
Conversation
|
could it decoupled from aws s3. It could be a decorator. Same appoach we used for CacheResolver. |
|
Would it be possible to open a PR for |
|
ok, now completly decoupled from any Resolver, acts as transparent Decorator for every other Resolver |
|
mh symfony 2.0 fails, should we deprecate 2.0? could provide a patch, but is it good to support such an old versions long term? //cc @lsmith77 |
|
@digitalkaoz FYI develop branch (which would become 1.0 in near future) requires ~2.3 version. |
|
what means near future? :) |
|
|
||
| private function rewriteResponse($response) | ||
| { | ||
| if ($response instanceof RedirectResponse && $this->hosts) { |
There was a problem hiding this comment.
on develop branch, resolve method always return an url as a string.
when all release blockers will be solved and we are confident it is stable (I mean interfaces, the code already stable) There were huge changes already done: master...develop, you could look at UPGRADE.md file too |
|
I would really advice you to impl this feature over develop branch. |
You could use the headers directly |
|
mh ok, what if i make this one compatible with |
| @@ -0,0 +1,106 @@ | |||
| <?php | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Please apply the coding conventions. There are several empty lines duplicated. The file endings are wrong.
|
It's ok to me. The only thing not happening are BC breaks. Small features (such as filters, resolvers, ..) are absolutely fine to be merged into master, too. |
|
line endings? i dont think so, i have a btw, can we tag the current master? :) |
|
No, not line endings, but file endings (empty line at the end missing). |
|
|
ok travis thinks its ok now :) |
|
can we tag it again? :) ah already done :) thank you :) |
see the attached doc for more details...
tldr;
adds the ability to use any resolver within the Proxy Cache-Resolver
see the docs for more details