added background_image filter #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @author Robert Schönthal <robert.schoenthal@sinnerschrader.com> | ||
| */ | ||
| class BackgroundImageFilterLoader implements LoaderInterface |
There was a problem hiding this comment.
What is the difference from BackgroundFilterLoader which we already have?
There was a problem hiding this comment.
maybe it would be better to impr exist one.
|
ok merged it with the default background filter |
| $size = $image->getSize(); | ||
|
|
||
| if (isset($options['size'])) { | ||
| list($w, $h) = $options['size']; |
There was a problem hiding this comment.
I would personally prefer long var names.
|
looks good to me, is it possible to add a test? |
|
ok fixed the cosmetics, i dont have written a test because there arent any FilterTests at all ;) |
| @@ -141,6 +141,7 @@ | |||
| <tag name="liip_imagine.filter.loader" loader="crop" /> | |||
| </service> | |||
|
|
|||
|
|
|||
|
Minor tweaks and squash, then it's good to go :-) |
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tweaked the background filter:
The
backgroundfilterThe background filter can now create a background-image with dimensions and color, default is white (#FFF). where you can put other images/filters ontop
Configuration looks like this: