improved exception on generation failure #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $image = $this->dataManager->find($filter, $path); | ||
| $response = $this->filterManager->get($request, $filter, $image, $path); | ||
| } catch (RuntimeException $e) { | ||
| throw new RuntimeException('unable to create image for '.$path.' error was: '.$e->getMessage(), 0, $e); |
There was a problem hiding this comment.
Why are you catching an exception and throwing the very same exception (with different content)? There is no use to this.
There was a problem hiding this comment.
i catch and rethrow to get the requested file in my logging. E.g. the PROD logs wont show the faulty image, only that someting went wrong, now you have the requested file in your logs, and can investigate furher
There was a problem hiding this comment.
Ok, I understand the request, but you have the URL where the exception was raised?
I'm not against this, if it helps, I'm fine. But the exception being thrown by this bundle has to be changed. It's not valid to throw an exception of a different vendor, that's what the previous is for.
<?php
throw new \RuntimeException(sprintf('Unable to create image for path "%s" and filter "%s".', $path, $filter), 0, $e);
|
ok fixed it |
havvg
added a commit
that referenced
this pull request
Feb 7, 2014
improved exception on generation failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include the requested image in exception message when the generation failed