Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli command to resolve cache #379

Merged
merged 7 commits into from
Apr 3, 2014
Merged

Conversation

serdyuka
Copy link
Contributor

@serdyuka serdyuka commented Apr 3, 2014

it fixes #376

@makasim makasim added the Feature label Apr 3, 2014
@makasim makasim added this to the v1.0.0 milestone Apr 3, 2014
@makasim makasim self-assigned this Apr 3, 2014
@serdyuka
Copy link
Contributor Author

serdyuka commented Apr 3, 2014

@makasim please review

protected function configure()
{
$this
->setName('liip_imagine:cache:resolve')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name it liip:imagine:cache:resolve to be compatible with other liips bundle, for example doctrine cache bundle has a commandliip:doctrine-cache:clear`.

@serdyuka
Copy link
Contributor Author

serdyuka commented Apr 3, 2014

@makasim please review again

protected function configure()
{
$this
->setName('liip_imagine:cache:resolve')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serdyuka still not valid

makasim added a commit that referenced this pull request Apr 3, 2014
@makasim makasim merged commit dd463e0 into liip:master Apr 3, 2014
@makasim makasim deleted the resolve-from-cli branch April 3, 2014 13:33
@makasim
Copy link
Collaborator

makasim commented Apr 3, 2014

thanks @serdyuka

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Level: New Feature 🆕 This item involves the introduction of new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.0] A command allows to resolve cache from cli.
2 participants