-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move data loaders to binary folder #382
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,7 +14,7 @@ liip_imagine: | |
Add loader to your services: | ||
|
||
``` xml | ||
<service id="liip_imagine.data.loader.grid_fs" class="Liip\ImagineBundle\Imagine\Data\Loader\GridFSLoader"> | ||
<service id="liip_imagine.data.loader.grid_fs" class="Liip\ImagineBundle\Binary\Loader\GridFSLoader"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
same for others. |
||
<tag name="liip_imagine.data.loader" loader="grid_fs" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. tag name has also be renamed, dont forget to mention it in the UPGRADE.md |
||
<argument type="service" id="liip_imagine" /> | ||
<argument type="service" id="doctrine.odm.mongodb.document_manager" /> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
|
||
namespace Liip\ImagineBundle\Tests\Imagine\Data\Loader; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Move tests to Liip\ImagineBundle\Tests\Binary\Loader; |
||
|
||
use Liip\ImagineBundle\Imagine\Data\Loader\FileSystemLoader; | ||
use Liip\ImagineBundle\Binary\Loader\FileSystemLoader; | ||
use Symfony\Component\Filesystem\Filesystem; | ||
use Symfony\Component\HttpFoundation\File\MimeType\ExtensionGuesser; | ||
use Symfony\Component\HttpFoundation\File\MimeType\ExtensionGuesserInterface; | ||
|
@@ -27,9 +27,9 @@ public static function provideLoadCases() | |
|
||
public function testShouldImplementLoaderInterface() | ||
{ | ||
$rc = new \ReflectionClass('Liip\ImagineBundle\Imagine\Data\Loader\FileSystemLoader'); | ||
$rc = new \ReflectionClass('Liip\ImagineBundle\Binary\Loader\FileSystemLoader'); | ||
|
||
$this->assertTrue($rc->implementsInterface('Liip\ImagineBundle\Imagine\Data\Loader\LoaderInterface')); | ||
$this->assertTrue($rc->implementsInterface('Liip\ImagineBundle\Binary\Loader\LoaderInterface')); | ||
} | ||
|
||
public function testCouldBeConstructedWithExpectedArguments() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
liip_imagine.data.loader.xxx.class
->liip_imagine.binary.loader.xxx.class