Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update template extension and helper names #41

Merged
merged 2 commits into from
Dec 18, 2011
Merged

update template extension and helper names #41

merged 2 commits into from
Dec 18, 2011

Conversation

iampersistent
Copy link
Contributor

I have a situation where I want to use parts of LiipImagineBundle with AvalacheImagineBundle in the same site. Right now, since both template extension and helpers have the same name, one cancels out the other. A simple name change fixes that.

@lsmith77
Copy link
Contributor

i am not that familiar with the template helper .. but the entire point of the name is to be unique, it has no impact on the user of the Bundle if they are renamed? aka they should really always include the entire bundle name?

lsmith77 added a commit that referenced this pull request Dec 18, 2011
update template extension and helper names
@lsmith77 lsmith77 merged commit 414db43 into liip:master Dec 18, 2011
@stof
Copy link
Contributor

stof commented Dec 18, 2011

@lsmith77 the name is used to access them:

<?php $view['liip_imagine']->applyFilter(); ?>

For the Twig extension, the user should indeed never need to use the name. The compiled template does (so changing the name requires clearing the Twig cache)

@lsmith77
Copy link
Contributor

ok thx .. thats what i figured in the end and which is why i merged the change .. conveniently we don't even document the php view helper :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants