-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GridFSLoader #461
Fix GridFSLoader #461
Conversation
It seems that a previously suggested patch never made it into the repo (cf. issue liip#305)
Can you merge this one? It is the same as in #331 and is not working. It would be great if you could tag a new minor release as well. |
There were several commits that reverts previous work. Let's say one commit changes I think both variants has to be supported. |
What we could do is to check if $image['file'] exists and if not use the getter. I dont see why there should be access as array possible.... |
According to the history it was fixed in 0.x. https://github.com/liip/LiipImagineBundle/commits/0.x/Imagine/Data/Loader/GridFSLoader.php But 1.x somehow misses this change: https://github.com/liip/LiipImagineBundle/blob/master/Binary/Loader/GridFSLoader.php I think we can merge this as is |
Awesome, thanks 👍 |
Thanks guys :-) |
It seems that a previously suggested patch never made it into the repo (cf. issue #305)