add composer.json #51
Conversation
|
|
||
| "require": { | ||
| "php": ">=5.3.2", | ||
| "imagine/Imagine": "master-dev" |
There was a problem hiding this comment.
this is wrong. First, master-dev does not exist anymore, and second, you should not depend on it (it would imply that you can guarantee the compatibility with any future state of the master branch)
There was a problem hiding this comment.
oh, and the bundle depends on FrameworkBundle too
There was a problem hiding this comment.
So this should just be "*" instead?
There was a problem hiding this comment.
no, * is bad too. Do you know any future release of Imagine to ensure that your current release of the bundle will always work with them ? No. So you need an upper bound on the constraint
There was a problem hiding this comment.
Now I feel incredibly dumb :p That's pretty obvious, especially after you explain it a second time. Thanks. I'll fix it later today.
|
ping .. |
| "require": { | ||
| "php": ">=5.3.2", | ||
| "imagine/Imagine": "<=0.2.8", | ||
| "symfony/framework-bundle": "2.0.*" |
There was a problem hiding this comment.
the bundle is compatible with 2.1 too AFAIK
|
@stof, would "2.0., 2.1." do the job on that? |
|
@iampersistent no. the comma is a AND, not a OR. you need to expand the constraint manually for this: |
|
@stof, thanks, I appreciate you being patient and educating me |
I can't promise it works, I'm just starting to play with composer. I'll get it working if its wrong.