Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix invalid in_array #565

Merged
merged 2 commits into from
Feb 22, 2015
Merged

fix invalid in_array #565

merged 2 commits into from
Feb 22, 2015

Conversation

digitalkaoz
Copy link
Contributor

under some circumstances it seems $index is not always an array. therefore we do the default stuff

@digitalkaoz
fix invalid in_array
a1f7e2f 
under some circumstances it seems `$index` is not always an array. therefore we do the default stuff
@lsmith77
Copy link
Contributor

why not just cast to an array before hand?

@digitalkaoz
Copy link
Contributor Author

obviously simple, so yeah :)

makasim added a commit that referenced this pull request Feb 22, 2015
@makasim
Merge pull request #565 from digitalkaoz/patch-2
a97b46f 
fix invalid in_array
@makasim makasim merged commit a97b46f into liip:master Feb 22, 2015
@makasim
Copy link
Collaborator

makasim commented Feb 22, 2015

thanks.

@digitalkaoz
Copy link
Contributor Author

can we tag a new release?

@digitalkaoz digitalkaoz deleted the patch-2 branch February 23, 2015 11:38
@makasim
Copy link
Collaborator

makasim commented Feb 23, 2015

Sure: https://github.com/liip/LiipImagineBundle/releases/tag/1.2.3

@digitalkaoz
Copy link
Contributor Author

merci :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@digitalkaoz @lsmith77 @makasim