-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file transformers to the file loader #57
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
<?php | ||
|
||
namespace Liip\ImagineBundle\Imagine\Data\Loader; | ||
|
||
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException; | ||
|
||
use Imagine\Image\ImagineInterface; | ||
|
||
class ExtendedFileSystemLoader extends FileSystemLoader | ||
{ | ||
/** | ||
* | ||
* @var array | ||
*/ | ||
private $transformers; | ||
|
||
/** | ||
* Constructs | ||
* | ||
* @param ImagineInterface $imagine | ||
* @param array $formats | ||
* @param string $rootPath | ||
* @param array $transformers | ||
*/ | ||
public function __construct(ImagineInterface $imagine, $formats, $rootPath, array $transformers) | ||
{ | ||
parent::__construct($imagine, $formats, $rootPath); | ||
$this->transformers = $transformers; | ||
} | ||
|
||
/** | ||
* Apply transformers to the file | ||
* | ||
* @param $absolutePath | ||
* @return array | ||
*/ | ||
protected function getFileInfo($absolutePath) | ||
{ | ||
if (!empty($this->transformers)) { | ||
foreach ($this->transformers as $transformer) { | ||
$absolutePath = $transformer->applyTransform($absolutePath); | ||
} | ||
} | ||
return pathinfo($absolutePath); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -91,4 +91,4 @@ public function find($path) | |
|
||
return $this->imagine->open($absolutePath); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
<?php | ||
|
||
namespace Liip\ImagineBundle\Imagine\Data\Transformer; | ||
|
||
class PdfTransformer | ||
{ | ||
public function applyTransform($absolutePath) | ||
{ | ||
$info = pathinfo($absolutePath); | ||
if (isset($info['extension']) && strpos(strtolower($info['extension']), 'pdf') !== false) { | ||
//Check if Imagick extension is loaded | ||
if (!extension_loaded('Imagick')) | ||
throw new \RuntimeException ("PHP Imagick extension is not loaded but required by the PdfTransformer"); | ||
|
||
//If it doesn't exists extract the first page of the PDF | ||
if (!file_exists("$absolutePath.png")) { | ||
$img = new \Imagick($absolutePath.'[0]'); | ||
$img->setImageFormat('png'); | ||
$img->writeImages($absolutePath.'.png', true); | ||
} | ||
//finally update $absolutePath | ||
$absolutePath .= '.png'; | ||
} | ||
return $absolutePath; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -141,4 +141,4 @@ | |
</service> | ||
|
||
</services> | ||
</container> | ||
</container> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not omit curly brackets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opps .. i also noticed another thing. i would prefer it if we would inject the Imagick instance .. i don't have experience with its API .. but i assume we could also call setFilename() instead of passing the absolute path to the constructor? could you do a PR to change this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm actually it seems Imagine itself is using the same approach .. the Imagick OO API also seems a bit strange:
https://github.com/avalanche123/Imagine/blob/master/lib/Imagine/Imagick/Imagine.php
@avalanche123 do you have a tip for us here what would make the most sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. It would be better. I'm checkin the API and PR the changes!