Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AwsS3Resolver compatible with SDK v3 #605

Merged
merged 2 commits into from
Jun 2, 2015
Merged

Make AwsS3Resolver compatible with SDK v3 #605

merged 2 commits into from
Jun 2, 2015

Conversation

cdaguerre
Copy link
Contributor

AwsS3Resolver is not compatible with AWS SDK v3 released earlier today because Enum constants were removed (refer: http://docs.aws.amazon.com/aws-sdk-php/v3/guide/guide/migration.html#enum-classes-have-been-removed)

This simple commit should make the resolver compatible with v3.

@lsmith77
Copy link
Contributor

looks good to me .. @makasim ?

@lsmith77 lsmith77 added in progress State: Reviewing This item is being reviewed to determine if it should be accepted. labels May 29, 2015
@lsmith77
Copy link
Contributor

BTW I guess this line should also be updated then to include v3:
https://github.com/liip/LiipImagineBundle/blob/master/composer.json#L45

@cdaguerre
Copy link
Contributor Author

@lsmith77 composer.json updated.

@lsmith77
Copy link
Contributor

thx

@makasim
Copy link
Collaborator

makasim commented Jun 2, 2015

require-dev rely on 2.4 version of SDK, not sure we have to keep it or update it, any thoughts?

@cdaguerre
Copy link
Contributor Author

@makasim Actually I wasn't sure either.

I updated aws/aws-sdk-php to v3 locally and ran the unit test suite (excluding functional). I only got a bunch of symfony deprecation warnings due to the new version of the debug component, so I guess it works as expected and as it used to with v2.

According to the AWS migration guide:

  • Given the _"data-driven and API version agnostic nature of Version 3"_, I guess this means from v3.0 on, the resolver should work with any new release and API version.
  • They also state they will follow strict SemVer standards from now on.

So my guess is: If it works with v2 and there should be no BC breaks going forward (at least in the v3.0 branch), we might aswell update the composer requirement.

makasim added a commit that referenced this pull request Jun 2, 2015
Make AwsS3Resolver compatible with SDK v3
@makasim makasim merged commit e9a2fa1 into liip:master Jun 2, 2015
@lsmith77 lsmith77 removed the State: Reviewing This item is being reviewed to determine if it should be accepted. label Jun 2, 2015
@cdaguerre cdaguerre deleted the aws-sdk-v3 branch June 3, 2015 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants