Make it easier to get a dev environment up and running #613
Conversation
lstrojny
commented
Jun 30, 2015
lstrojny
commented
- Moves the ODM extension to suggest
- Ignores a few more directories
- Installs ODM for CI
lsmith77
added
the
State: Reviewing
| @@ -16,6 +16,7 @@ before_script: | |||
| - sh -c 'if [ "${TRAVIS_PHP_VERSION}" != "hhvm" ]; then echo "memory_limit = -1" >> ~/.phpenv/versions/$(phpenv version-name)/etc/conf.d/travis.ini; fi;' | |||
| - composer require symfony/symfony:${SYMFONY_VERSION} --prefer-source | |||
| - composer install --dev --prefer-source | |||
| - composer require doctrine/mongodb-odm ~1.0.3 | |||
There was a problem hiding this comment.
why not put this into require-dev ?
There was a problem hiding this comment.
ah .. the point is not forcing mongodb odm for local dev?
|
what is the problem with the ODM being installed by default? does it cause issues during composer install if you do not have the mongo ext installed? seems like in the tests everything is mocked anyway .. |
|
Personally I dont like this approach (having partial environments) |
|
The env has to be the same for all developers and CI. |
|
@lsmith77 you can't run composer install as ODM depends on ext-mongodb which might not be installed. For dev-dependencies I would try to not depend on dependencies, that are hard(er) to install, like PECL extensions. I am probably a good example for the issue, as everytime I want to do something on LiipImagineBundle I have to first edit the composer.json at least temporarily to get a dev env up an running. Not very optimal. |
|
I see your point .. or more importantly .. people tend not to be aware of |
|
@lsmith77 not sure I understand what you mean by "but I do like the 'skip test' but it should be in the extension" |
| @@ -23,6 +23,10 @@ class GridFSLoaderTest extends \PHPUnit_Framework_TestCase | |||
|
|
|||
| public function setUp() | |||
| { | |||
| if (!class_exists('Doctrine\ODM\MongoDB\DocumentRepository')) { | |||
| $this->markTestSkipped('Doctrine ODM not installed'); | |||
There was a problem hiding this comment.
in case our tests require the mongo pecl ext as well to run, we should also check for their existence to determine if to skip
There was a problem hiding this comment.
Ah, I thought it would be sufficient to check for ODM, as that’s the one that requires ext/mongodb. My idea was to check for the highest abstraction and not all the way down. But I don’t mind adding it.
|
OK, basically what’s left is the test for the extension. The rest has been reverted. Should be good to go now. |
Make it easier to get a dev environment up and running
lsmith77
removed
the
State: Reviewing
|
thx! |
