Return string, not Twig_Markup object in Twig extension #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsmith77
added
the
State: Reviewing
lsmith77
added a commit
that referenced
this pull request
Jul 2, 2015
Return string, not Twig_Markup object in Twig extension
lsmith77
removed
the
State: Reviewing
|
This is a BC break IMO. I believe it was done (wrapping to Twig_Markup) on purpose to solve the problem we had, cannot recall which one though |
|
i guess 54cfe94 |
|
I recall, We had double url encoding and to avoid this Twig_Markup was added. |
|
I guess I found: #314 |
|
Wouldn’t it be better to mark the function as HTML safe then? |
|
@lstrojny avoiding autoescaping looks really weird here, because the method does not return some HTML, and it is not safe for HTML (it returns an URL, which is not safe for HTML context as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning a markup object breaks interoperability with the Symfony assets extension. More details here: symfony/symfony#15158