Incorporate feedback from @WouterJ for PR 651 #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @wouterj |
|
hmm .. strange that StyleCI is failing so badly .. can you make sure your branch is rebased on master? |
|
@lsmith77, sure, will check. |
|
@lsmith77, rebased, sorry for the mishap |
lsmith77
added
the
State: Reviewing
|
|
||
| <img src="<?php $this['imagine']->filter('/relative/path/to/image.jpg', 'my_thumb', $runtimeConfig) ?>" /> | ||
| <img src="<?php $this['imagine']->filter('/relative/path/to/image.jpg', 'my_thumb', $runtimeConfig) ?>" /> |
|
👍 |
lsmith77
added a commit
that referenced
this pull request
Oct 27, 2015
Incorporate feedback from @wouterj for PR 651
lsmith77
removed
the
State: Reviewing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues in
basic_usage.rstmentioned in PR 651: