- Task: correctly handles all rotations, even those involving flippin… #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please do not use short open tags .. I assume styleci initially told you that you need to use it before you rebased .. because the default config specifies short open tags, while the config in master defines that it should not be used. |
|
|
|
argh .. I meant short array syntax :) |
| @@ -11,22 +11,27 @@ | |||
| */ | |||
| class AutoRotateFilterLoader implements LoaderInterface | |||
| { | |||
| protected $orientationKeys = array( | |||
| protected $orientationKeys = [ | |||
There was a problem hiding this comment.
please do not use short array syntax
|
Yes I just noticed about the short array syntax. Should I do another commit or you already modified it? |
|
yeah please fix in another commit or by force pushing on the last commit |
lsmith77
added a commit
that referenced
this pull request
Oct 29, 2015
- Task: correctly handles all rotations, even those involving flippin…
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly handles all rotations, even those involving flipping horizontally.