Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebased commands document patch, see #533 #680

Merged
merged 4 commits into from
Dec 28, 2015
Merged

Conversation

helios-ag
Copy link
Contributor

Rebased patch #533

@makasim
Copy link
Collaborator

makasim commented Dec 18, 2015

The documentation format is not github's markdown. See how other docs are formatted.

ping @javiereguiluz

@javiereguiluz
Copy link
Contributor

@helios-ag I'm afraid @makasim is right. The documentation of this bundle must follow Symfony practices because we display it on symfony.com/doc . If you are not familiar with the new format, please review these two quick articles: http://symfony.com/doc/current/contributing/documentation/format.html and http://symfony.com/doc/current/contributing/documentation/standards.html

@lsmith77 lsmith77 added the State: Reviewing This item is being reviewed to determine if it should be accepted. label Dec 18, 2015
@helios-ag
Copy link
Contributor Author

file updated, @javiereguiluz

@javiereguiluz
Copy link
Contributor

@helios-ag very nice! Thanks.

Minor comment: maybe this line is too long and it could be wrapped at 80 characters: https://github.com/liip/LiipImagineBundle/pull/680/files#diff-887f7928659ec2ad4990a59f5c3c0f82R64

@helios-ag
Copy link
Contributor Author

@javiereguiluz comments reviewed, changes applied.

@makasim
Copy link
Collaborator

makasim commented Dec 28, 2015

@javiereguiluz Could you please review. I need your confirm to merge this

.. code-block:: bash

$ php app/console liip:imagine:cache:remove path1 path2 --filters=thumb1 --filters=thumb2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unneeded extra blank line.

@javiereguiluz
Copy link
Contributor

@makasim done! Everything is fine except some minor issues with blank lines.

@makasim
Copy link
Collaborator

makasim commented Dec 28, 2015

@javiereguiluz thank you very much.

@helios-ag
Copy link
Contributor Author

@makasim done

makasim added a commit that referenced this pull request Dec 28, 2015
rebased commands document patch, see #533
@makasim makasim merged commit c47c31c into liip:master Dec 28, 2015
@lsmith77 lsmith77 removed the State: Reviewing This item is being reviewed to determine if it should be accepted. label Dec 28, 2015
@makasim
Copy link
Collaborator

makasim commented Dec 28, 2015

@helios-ag Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants