Fixed config issue with AWS SDK v3 in AwsS3ResolverFactory #683
Conversation
|
What if we add a new factory for v3 sdk? Same time we can deprecate curent aws factory. It would be good if you can add some docs on when to use what factory. Sounds good? |
|
@kieste are you planning to finish this PR? |
|
Yes I will fix this before end of the year. |
|
@makasim separated old and new SDK client config code into different factory classes. Added a note to the documentation. |
| @@ -32,7 +33,11 @@ public function build(ContainerBuilder $container) | |||
| $extension = $container->getExtension('liip_imagine'); | |||
|
|
|||
| $extension->addResolverFactory(new WebPathResolverFactory()); | |||
| $extension->addResolverFactory(new AwsS3ResolverFactory()); | |||
| if (defined('\Aws\Sdk::VERSION') && version_compare(\Aws\Sdk::VERSION, '3.0.0', '>=')) { | |||
There was a problem hiding this comment.
register both, and let a developer decided which one to use. Also would be good to add an exception if a resolver is used with wrong sdk.
|
@makasim after taking a closer look at my current setup I realized that I am not using the factories any more. (Currently I am creating the AwsS3Resolver as a service and injecting it directly into a proxy resolver.) So I can't finish this pull request now with your suggested changes. (I must progress with my current project.) But I aggree to all of your comments. This totally makes sense. But it's too much effort for me at the moment. |
lsmith77
added
the
State: Reviewing
lsmith77
removed
the
State: Reviewing
|
Thanks for your contribution, I took care of your PR. Soon in the master |
I just modified the pull request from glenn-- so that his changes pass PHP 5.3 checks.