[resolver] Add ability to force resolver. #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsmith77
added
the
State: Reviewing
makasim
force-pushed
the
force-resolver
branch
from
d50bb97 to
dfc626f
Compare
…veral conf files.
makasim
added a commit
that referenced
this pull request
Dec 27, 2015
[resolver] Add ability to force resolver.
lsmith77
removed
the
State: Reviewing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem: Right now filters are coupled to resolvers (or vice versa) and it limits us a lot. For example we are not able to use s3 links in the backend (without cdn cache) and cdn links on frontend. This could be achieved right now by duplicating all filters + a prefix. The other problem: We are not able to reuse filters with different resolvers. We have to duplicate them all the time.
Solution: The big goal is to decouple resolvers from filters, and ideally data loaders from filters too. It'll be done for v2 and most likely there will be BC breaks.
This PR just adds ability to force the resolver, it is a small step towards the bigger goal. it is BC way.