Add Flysystem resolver #715
Conversation
|
There's a syntax error in the current symfony branch for 2.7. |
lsmith77
added
the
State: Reviewing
|
the PR was merged .. I have retriggered the tests |
|
Great. Thx. |
|
All is green. Is there anything I can do to make this change more attractive? |
|
👍 Looks like a super useful feature! |
|
The CI was triggered because of a rebase. Tests are still green and the styleci fail is not on anything I touched :) |
|
@cedricziel I really want this one to be merged ^^ can you fix the styleCI ? |
As a counterpart to the flysystem loader, using this resolver it is also possible to store the cached filter-files in flysystem adapters. * add FlysystemResolver * add tests for FlysystemResolver * add documentation for FlysystemResolver * exclude correct `Tests` folder from scrutinizer analysis
|
So do I - and sure I can. I was just hesitating that it might break some other PRs. Here we go. |
|
great :-), it looks like @lsmith77 has now the power button ^^ |
| /** | ||
| * @var Filesystem | ||
| */ | ||
| protected $flysystem; |
There was a problem hiding this comment.
I'd like to keep the name flysystem. Is this a major problem?
|
will this work with not local flysystem filesystem, let's an amazon s3 one? |
|
@makasim Sure. Flysystem encapsulates all the logic for retrieving and storing files so one flysystem instance is as good as another one-be it local or remote. |
|
Hello there - is there anything holding you back from merging this one? I'd be happy to adjust my code if needed. |
lsmith77
removed
the
State: Reviewing
|
thx .. and sorry for the delay .. the Bundle needs more maintainer love :-/ |
|
Great, thank you for merging! |
|
Thank you for the merge! Let me know if I can be of any help. |
As a counterpart to the flysystem loader, using this resolver
it is also possible to store the cached filter-files in
flysystem adapters.
Testsfolder from scrutinizer analysis