Add visibility argument to flysystem resolver #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this, there was no way to modify the visibility in a central place, which was fine for local resolvers, or with predefined acls. This changeset introduces a new `visibility` argument on the FlysystemResolver that will be taken into account everytime a cache object is written to a flysystem filesystem. The default is public, so that cached objects are accessible from the outside, which should be sensible.
cedricziel
force-pushed
the
flysystemVisibility
branch
from
25d29e2 to
b1335f8
Compare
|
👍 Are there any other config options which can be exposed this way? (Took a look and couldn't see anything obvious!) |
|
Most options are really adapter specific and those are configured on the underlying adapter instances. So far I think only visibility is really a shared option. I thought about a mechanism for custom arguments, but that is something for another PR. We are already using the pull-request branch in production and visibility was really the only thing I had an urgent need for. Thank you for reviewing, I consider it done, unless you you want me to correct something :) |
lsmith77
added
the
State: Reviewing
lsmith77
removed
the
State: Reviewing
robfrawley
added a commit
to src-run/liip-imagine-bundle-sandbox
that referenced
this pull request
Sep 9, 2016
lsmith77
added a commit
that referenced
this pull request
Sep 15, 2016
Bugfix for Failing Tests Introduced in #777
robfrawley
added a commit
to src-run/liip-imagine-bundle-sandbox
that referenced
this pull request
Sep 15, 2016
robfrawley
added a commit
to src-run/liip-imagine-bundle-sandbox
that referenced
this pull request
Sep 15, 2016
jehaby
pushed a commit
to src-run/liip-imagine-bundle-sandbox
that referenced
this pull request
Sep 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, there was no way to modify the visibility in a central place,
which was fine for local resolvers, or with predefined acls.
This changeset introduces a new
visibilityargument on the FlysystemResolverthat will be taken into account everytime a cache object is written to a flysystem
filesystem.
The default is public, so that cached objects are accessible from the outside,
which should be sensible.