Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md and RST Doc Refactoring / LICENSE.md Inclusion / File-Level Doc-Blocks #781

Closed
wants to merge 1 commit into from

Conversation

robfrawley
Copy link
Collaborator

@robfrawley robfrawley commented Sep 3, 2016

@lsmith77 lsmith77 added the State: Reviewing This item is being reviewed to determine if it should be accepted. label Sep 5, 2016
@lsmith77
Copy link
Contributor

lsmith77 commented Sep 5, 2016

don't have time today to review in detail but looks like a good idea in general.

however I would not add .editorconfig.

@robfrawley
Copy link
Collaborator Author

Just wondering why the dislike of an .editorconfig file? No worries, though: I'll remove that shortly. I have another large pull request waiting in-the-wings for after this one is approved that raises test coverage to 78% and refactors some tests/code: https://github.com/liip/LiipImagineBundle/compare/master...robfrawley:feature-refactor-tests?expand=1

@robfrawley robfrawley force-pushed the feature-license branch 2 times, most recently from ff41954 to 0c3ef7e Compare September 6, 2016 06:53
@robfrawley
Copy link
Collaborator Author

robfrawley commented Sep 6, 2016

Rebased on top of latest master, fixes merge conflict caused by pull request #779. Removed .editorconfig. Refactored RST docs.

squash 12 commits

squash 11 commits

squash 10 commits

license and readme updates

readme bugfix

readme bugfix

readme bugfix

readme bugfix

bugfix

bugfix

bugfix

removal of editor config file

updated to RST docs and README

additional docs fixes and updates

updated readme for updated RST links

updates to RST docs
@robfrawley
Copy link
Collaborator Author

robfrawley commented Sep 6, 2016

@robfrawley robfrawley changed the title README.md Refactoring / LICENSE.md Inclusion / File-Level Doc-Blocks README.md and RST Doc Refactoring / LICENSE.md Inclusion / File-Level Doc-Blocks Sep 6, 2016
@alexwilson
Copy link
Collaborator

alexwilson commented Sep 6, 2016

Actually I'm wrong - But the CHANGELOG.md file reads that we have distributed the CCv3 by-nc-sa! https://github.com/liip/LiipImagineBundle/pull/781/files#diff-4ac32a78649ca5bdd8e0ba38b7006a1eR4

@@ -1,6 +1,11 @@
Changelog
=========

* **2016-09-03**: [License] Created markdown version of *Creative Commons
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LICENSE.md is the MIT license!

@alexwilson
Copy link
Collaborator

For the header is it worth adding an @license MIT?

@alexwilson alexwilson mentioned this pull request Sep 6, 2016
@alexwilson
Copy link
Collaborator

alexwilson commented Sep 6, 2016

Given the status of our CHANGELOG, honestly I think it flat-out be worth removing from the scope of this PR so that we can decide what to do with it at a later date. Sorry to be so much trouble!

Could you please also use a slightly more descriptive commit message? Granted there's a lot going in here (arguably it should be split between different PRs due to the wide scope - here's why I'm so much of a stickler about that).

@robfrawley
Copy link
Collaborator Author

@antoligy: Yeah, so I don't even need to read the link you provided to know what you're getting at and agree; this PR ballooned way out of its initial scope and has just kept getting bigger. Best kill it now. ;-)

Closed in favor of #788, #789, #790, and #791.

@robfrawley robfrawley closed this Sep 7, 2016
@lsmith77 lsmith77 removed the State: Reviewing This item is being reviewed to determine if it should be accepted. label Sep 7, 2016
@robfrawley robfrawley mentioned this pull request Sep 7, 2016
@robfrawley robfrawley deleted the feature-license branch January 28, 2017 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants