-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README.md and RST Doc Refactoring / LICENSE.md Inclusion / File-Level Doc-Blocks #781
Conversation
robfrawley
commented
Sep 3, 2016
•
edited
Loading
edited
- Updated README.md (see https://github.com/robfrawley/LiipImagineBundle/blob/feature-license/README.md to reference how the changes are rendered).
- Refactored RST docs (see https://src.run/docs/symfony-build/liipimaginebundle/index.html to reference how the changes are rendered).
- Added LICENSE.md
- Added file-level doc-blocks
don't have time today to review in detail but looks like a good idea in general. however I would not add |
Just wondering why the dislike of an |
ff41954
to
0c3ef7e
Compare
Rebased on top of latest master, fixes merge conflict caused by pull request #779. Removed |
0c3ef7e
to
e351059
Compare
squash 12 commits squash 11 commits squash 10 commits license and readme updates readme bugfix readme bugfix readme bugfix readme bugfix bugfix bugfix bugfix removal of editor config file updated to RST docs and README additional docs fixes and updates updated readme for updated RST links updates to RST docs
e351059
to
0ce4318
Compare
See the updated RST output at https://src.run/docs/symfony-build/liipimaginebundle/index.html (Built using https://github.com/fabpot/sphinx-php and https://github.com/symfony/symfony-docs/tree/master/_build) |
Actually I'm wrong - But the CHANGELOG.md file reads that we have distributed the CCv3 by-nc-sa! https://github.com/liip/LiipImagineBundle/pull/781/files#diff-4ac32a78649ca5bdd8e0ba38b7006a1eR4 |
@@ -1,6 +1,11 @@ | |||
Changelog | |||
========= | |||
|
|||
* **2016-09-03**: [License] Created markdown version of *Creative Commons |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LICENSE.md is the MIT license!
For the header is it worth adding an |
Given the status of our CHANGELOG, honestly I think it flat-out be worth removing from the scope of this PR so that we can decide what to do with it at a later date. Sorry to be so much trouble! Could you please also use a slightly more descriptive commit message? Granted there's a lot going in here (arguably it should be split between different PRs due to the wide scope - here's why I'm so much of a stickler about that). |