Update Source to Newly Merged Style Rule Additions #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robfrawley
force-pushed
the
bugfix-phpcsfixer-run
branch
from
d49f101 to
dcacf9f
Compare
robfrawley
changed the title
alexwilson
approved these changes
Sep 20, 2016
robfrawley
force-pushed
the
bugfix-phpcsfixer-run
branch
from
dcacf9f to
cec4e71
Compare
lsmith77
added
the
State: Reviewing
lsmith77
reviewed
Sep 20, 2016
| @@ -132,7 +141,7 @@ public function store(BinaryInterface $binary, $path, $filter) | |||
| $this->flysystem->put( | |||
| $this->getFilePath($path, $filter), | |||
| $binary->getContent(), | |||
| ['visibility' => $this->visibility] | |||
There was a problem hiding this comment.
looks like this caught another use of short array syntax which means this isn't tested
There was a problem hiding this comment.
Yeah, the the travis file always excluded flysystem from PHP 5.3 runs. I assumed FlySystem requires a higher PHP version, but if that's not the case we should obviously be testing it! I'll take a look at flysystems composer when I get a second.
There was a problem hiding this comment.
@lsmith77 Yup, FlySystem requires PHP > 5.4, so that's why it is excluded from 5.3 builds on travis and why the above wasn't being tested.
lsmith77
removed
the
State: Reviewing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #791 (which was done prior to the new "style rules" and "php-cs-fixer bridge" additions using a hand crafted regex of mine - I feel more comfortable having a real code tokenizer/lexer do it instead, heh).
So, this is simple a PHP CS Fixer run using our new default rule set.
While the change set is substantial in size, its actually quite simple. All the changes relate to one of the following three rules:
The only, singular exception to my above assertion is a short-array to long-array syntax fix caught the fixer.
Hopefully people run this more often now! Remember, it's as easy as this now: