-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed #81 cache clearer only registered for sf2.1 #82
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,8 @@ | |
"require": { | ||
"php": ">=5.3.2", | ||
"imagine/Imagine": "<=0.2.8", | ||
"symfony/framework-bundle": ">=2.0,<2.2-dev" | ||
"symfony/framework-bundle": ">=2.0,<2.2-dev", | ||
"symfony/yaml": ">=2.0,<2.2-dev" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what is depending on yaml ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. its missing in the DIC tests...checked it out standalone, and it didnt get installed by composer. should it be installed for "symfony/framework-bundle" dep? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if it is only for the tests, it should go in |
||
}, | ||
|
||
"require-dev": { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should require
>=2.0.14
as you use the constant without doing adefined
check (which is fine IMO as we have 2 working releases in the 2.0 series already)