Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating 2.0 with corrections from 1.0 #820

Merged
merged 3 commits into from
Nov 3, 2016
Merged

Conversation

alexwilson
Copy link
Collaborator

No description provided.

@lsmith77 lsmith77 added the State: Reviewing This item is being reviewed to determine if it should be accepted. label Oct 31, 2016
@lsmith77 lsmith77 merged commit f8aa614 into 2.0 Nov 3, 2016
@lsmith77 lsmith77 deleted the image-cache-manager-typo branch November 3, 2016 07:06
@lsmith77 lsmith77 removed the State: Reviewing This item is being reviewed to determine if it should be accepted. label Nov 3, 2016
@robfrawley
Copy link
Collaborator

robfrawley commented Nov 5, 2016

@antoligy @lsmith77 Operations like this are much more appropriate as a CLI manual re-base than a PR/merge in the future, I would propose (IMHO).

Such avoids odd looking commit history like the duplication of commits and other oddities that may result (for example, see the commit duplicates on "Oct 30, 2016" on the 2.0 branch (that don't exist on 1.0) b/c of this PR. See https://github.com/liip/LiipImagineBundle/commits/2.0:

Notice the 1.0 branch only contains c1364db and 42bf661 as it should (and as should 2.0, but due to the oddities of GitHub graphical, auto-merge, it instead contains duplications)

@lsmith77
Copy link
Contributor

lsmith77 commented Nov 5, 2016

I personally do not feel passionate about keeping the history clean at this level. it really has never really bitten me. but if you prefer I am fine to keep an eye on this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants