[Filter] Upscale filter should use the highest dimension to calculate ratio #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwilson
requested changes
Jan 24, 2017
| @@ -70,7 +70,11 @@ public function load(ImageInterface $image, array $options = array()) | |||
| if (null == $width || null == $height) { | |||
| $ratio = max($widthRatio, $heightRatio); | |||
| } else { | |||
| $ratio = min($widthRatio, $heightRatio); | |||
| if('min' === $this->dimensionKey){ | |||
There was a problem hiding this comment.
Perhaps $ratio = ('min' === $this->dimensionKey) ? max($widthRatio, $heightRatio) : min($widthRatio, $heightRatio)?
| /** | ||
| * Test cases for UpScaleFilterLoader class. | ||
| * | ||
| * @covers Liip\ImagineBundle\Imagine\Filter\Loader\UpScaleFilterLoader |
There was a problem hiding this comment.
Casing on the class-name is a bit dodgy!
Also can the new test incorporated into ScaleLoader so that all the tests for this class are in one place?
alexwilson
added
the
State: Reviewing
robfrawley
approved these changes
Jan 24, 2017
There was a problem hiding this comment.
Outside of the changes @antoligy already requested, this looks find. 👍
cedricziel
approved these changes
Jan 25, 2017
|
Great, thank you for amending the changeset, @Rattler3 . @antoligy can you revisit and merge afterwards? |
robfrawley
added
Level: Bug 🐞
alexwilson
approved these changes
Jan 27, 2017
lsmith77
removed
the
State: Confirmed
|
Thank you for your contribution, @Rattler3 ! 🎉 |
|
Cheers guys, thanks for the quick turnaround! |
robfrawley
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for issue #855.
Reverts back to previous behaviour for upscale filter.
Closes: #855