[Symfony] Bug fixes and deprecation cleanup for Symfony 3.3 #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsmith77
added
the
State: Reviewing
robfrawley
added
Level: Bug 🐞
cedricziel
approved these changes
Jan 27, 2017
lsmith77
removed
the
State: Confirmed
|
Those changes are perfectly sane - thank you! |
|
Nice work! |
robfrawley
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to support Symfony
3.3, as well as remove deprecations generated from3.3.DefinitionDecorator(nowChildDefinition)https://github.com/liip/LiipImagineBundle/pull/860/files#diff-f6a2b0a892ed32df68cab49a06e21455R29
camelCaseNamedservices in our test suite (deprecated in3.3)https://github.com/liip/LiipImagineBundle/pull/860/files#diff-aa0a2d419bdf6d37e236ae7d365106c6R50
[...and more...]
translator: ~in functional test config file, as Symfony3.3requires this to enable thetranslatorservice, without which our functional tests brakehttps://github.com/liip/LiipImagineBundle/pull/860/files#diff-f9e984040c72fa157de966cc3cda08c9R15
https://github.com/liip/LiipImagineBundle/pull/860/files#diff-c863fd2e9ed73e8612993baa710cea85R24
[...and more...]