[DependencyInjection] Container logging for compiler passes #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsmith77
added
the
State: Reviewing
robfrawley
added
Level: New Feature 🆕
robfrawley
changed the title
robfrawley
force-pushed
the
bug-symfony-3.3-container-log
branch
from
86329e3 to
77f1c1d
Compare
robfrawley
force-pushed
the
bug-symfony-3.3-container-log
branch
from
77f1c1d to
4a6042f
Compare
lsmith77
removed
the
State: Confirmed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Container build logging for all compiler passes, including support for Symfony 3.3's new
logmethod (ContainerBuilder::log()). This would be much nicer as a trait, but due to our PHP 5.3 requirement, this is not an option; as such, an abstract class is used. :-(