Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Support PHPUnit 5.x (and remove depredations) #887

Merged
merged 1 commit into from
Mar 1, 2017

Conversation

robfrawley
Copy link
Collaborator

Q A
Branch? 1.0
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Support PHPUnit 5.x officially in composer.json and fix up unit tests to remove all deprecation warning introduced. Additional cleanup of unit tests included, as well.

@robfrawley robfrawley added the Level: New Feature 🆕 This item involves the introduction of new functionality. label Mar 1, 2017
@robfrawley robfrawley added this to the 1.7.3 milestone Mar 1, 2017
@robfrawley robfrawley self-assigned this Mar 1, 2017
@robfrawley robfrawley requested a review from alexwilson March 1, 2017 03:50
@lsmith77 lsmith77 added the State: Reviewing This item is being reviewed to determine if it should be accepted. label Mar 1, 2017
@robfrawley robfrawley changed the title [Travis] Support PHPUnit 5.x (removing depredations) [Tests] Support PHPUnit 5.x (removing depredations) Mar 1, 2017
@robfrawley robfrawley force-pushed the feature-support-phpunit-5.x branch from 373c36a to 95f959c Compare March 1, 2017 06:14
@robfrawley robfrawley changed the title [Tests] Support PHPUnit 5.x (removing depredations) [Tests] Support PHPUnit 5.x (and remove depredations) Mar 1, 2017
@robfrawley robfrawley modified the milestones: 1.7.4, 1.7.3 Mar 1, 2017
Copy link
Collaborator

@alexwilson alexwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very long diff, but I'm very happy with thisthis but I'm vthhappy with this

@robfrawley robfrawley modified the milestones: 1.7.3, 1.7.4 Mar 1, 2017
@robfrawley robfrawley merged commit 33fe389 into liip:1.0 Mar 1, 2017
@lsmith77 lsmith77 removed the State: Reviewing This item is being reviewed to determine if it should be accepted. label Mar 1, 2017
@robfrawley robfrawley mentioned this pull request Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Level: New Feature 🆕 This item involves the introduction of new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants