Revert adding leading slash to S3 class names

[cedricziel]

Closes: #892

Q	A
Branch?	1.0
Bug fix?	yes
New feature?	no
BC breaks?	/no
Deprecations?	no
Tests pass?	yes/no/maybe
Fixed tickets	#892
License	MIT

The service definition for the S3 resolver was changed slightly and instantiation broke for others. This change reverts it.

[cedricziel]

Ping @Chrysweel , @plozmun can you test the bugfix?

[rvanlaarhoven]

Thanks, this seems to resolve it

[Chrysweel]

Yes it resolve the problem.

But my question is .. why a commit added the / in definition class previously ?

[cedricziel]

Well, that's how bugs get introduced :)

Those kinds of refactorings will be much more stable when we raise the php version requirement and thus can use class constants.

[robfrawley]

Sorry guys, those got caught in a regex fixing FQCN in tests (which fixes some IDEs).

[robfrawley]

@cedricziel Is there anything we can do test-wise to ensure this regression is never introduced in the future?

[cedricziel]

@robfrawley hmm. I don't think it's worth the hassle. - we should much rather move on and rely on PHP for those in the future :)

Don't worry about it.

[cedricziel]

Ahh, @robfrawley - we need a bugfix release. Can you create one?

[robfrawley]

Yeah, on it.

[cedricziel]

Awesome! 🎉

[robfrawley]

Live!