Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the basePath in the file path resolver (useful in "_dev" or "_*" env... #92

Merged
merged 1 commit into from
Jul 23, 2012

Conversation

khepin
Copy link
Contributor

@khepin khepin commented Jul 23, 2012

...ironments when the script name is present in the url)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…environments when the script name is present in the url)
@lsmith77
Copy link
Contributor

@havvg ?

@khepin
Copy link
Contributor Author

khepin commented Jul 23, 2012

In previous commit from @havvg it is added as a 3rd parameter of getFilePath (which contradicts the interface implementation).
Inside of getFilePath, it calls $this->basePath which was never set before.

@havvg
Copy link
Contributor

havvg commented Jul 23, 2012

Oh, good catch!

I tried with '/app_dev.php' in configuration, which was the exact same result as the one of the request.
That's why it was working, while testing. Need to check my server configuration, why I didn't catch the warning.

Good to go, @lsmith77

lsmith77 added a commit that referenced this pull request Jul 23, 2012
Use the basePath in the file path resolver (useful in "_dev" or "_*" env...
@lsmith77 lsmith77 merged commit 455fe60 into liip:master Jul 23, 2012
@khepin
Copy link
Contributor Author

khepin commented Jul 23, 2012

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants