-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow v0.7 of Imagine Bundle #935
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of the test runs on Travis actually pull and test v0.7; we need to ensure the newer version is actually tested before merging this.
https://travis-ci.org/liip/LiipImagineBundle/jobs/232226661#L232
@robfrawley I've updated the travis config to test against 0.6 and 0.7. It looks like something has failed that isn't failed to the 0.7 change? Are you able to re-execute the tests on your end? |
@robfrawley any idea why that 1 test is failing? That wouldn't be from this PR's changes. |
I'll take a closer look at this |
Thank you. |
@trsteel88 Are you aware of any changes to the grayscale handling with the new Imagine library version? |
@robfrawley no I'm not. However, that failed test is on the older version anyway? It looks like it's only the php5.3 test failing running ~0.6 |
I re-executed it; let's see how that goes. Otherwise I'll but this PR and perform some local tests to determine what's going on. |
Any luck with your local tests @robfrawley? |
Hey @robfrawley, how can I help to get this progressed? |
We need to fix the merge conflicts and resolve the build failures, the latter of which I don't have too much time to figure out ATM. If you can make everything green I'd be happy to include it in the |
@trsteel88 Thanks for your PR; an alternate solution to resolve the issue mentioned in this PR has been opened as #958. |
php-imagine/Imagine#547