[Travis] Use "trusty" container image default with "precise" image for php 5.3 #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsmith77
added
the
State: Reviewing
alexwilson
approved these changes
Jun 6, 2017
cedricziel
approved these changes
Jun 6, 2017
lsmith77
removed
the
State: Reviewing
robfrawley
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You may have noticed that our latest build on Travis for the
1.xbranch has been stuck in failure for the past few weeks. First, it was the Twig bug twigphp/Twig#2499, but this was fixed upstream quickly once I reported it. Now the issue is that the Travis Ubuntu Precise container has dropped support for HHVM. The advertised resolution is to upgrade to the Ubuntu Trusty container, which is great, except it doesn't support PHP 5.3 anymore.So, the resolution here is to upgrade all builds to the Trusty container, except for PHP 5.3, which will continue using the Precise container. The only other change is, due to the removal of PHP 5.3 from the main
phparray in.travis.yml, we don't test this bundle with Symfony 2.8 using PHP 5.3, but only with the lowest dependencies. In short, PHP 5.3 is tested once instead of twice.This removes one additional build that I don't think is particularly necessary. Any objections?