Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for centerright and centerleft position #974

Merged
merged 1 commit into from
Aug 28, 2017
Merged

Added support for centerright and centerleft position #974

merged 1 commit into from
Aug 28, 2017

Conversation

cmodijk
Copy link
Contributor

@cmodijk cmodijk commented Aug 11, 2017 •
edited
Loading

Q A
Branch? 1.0
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR TODO If this gets accepted

Added support for centerright and centerleft position to the BackgroundFilterLoader

@cedricziel cedricziel merged commit 8e636c6 into liip:1.0 Aug 28, 2017
@cedricziel
Copy link
Collaborator

Thx @cmodijk !

@cmodijk cmodijk mentioned this pull request Aug 28, 2017
Merged
@cmodijk
Copy link
Contributor Author

cmodijk commented Aug 28, 2017

@cedricziel Your welcome i created a new PR to update the docs see #979

@robfrawley robfrawley mentioned this pull request Aug 31, 2017
Merged
robfrawley added a commit that referenced this pull request Sep 3, 2017
@robfrawley
Merge pull request #979 from cmodijk/patch-1
0595999 
Updated the docs for #974
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexwilson alexwilson alexwilson approved these changes

@cedricziel cedricziel cedricziel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmodijk @cedricziel @alexwilson