Fixing issue when using "traditional" path notation #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danrot can you verify that this fixes the issues? I guess it would be good to have a test case to catch such a regression in the future. |
xabbuh
reviewed
Oct 6, 2018
| )); | ||
|
|
||
| if (false === $container->has('templating')) { | ||
| $twigFilesystemLoaderDefinition->setArguments(array( |
There was a problem hiding this comment.
What about using replaceArgument() instead to not break in case the second argument was changed somewhere else?
There was a problem hiding this comment.
Great point @xabbuh, I will use the method replaceArgument().
However if the argument number for twig.loader.filesystem service change, the replaceArgument() method will throw an OutOfBoundsException.
|
@lsmith77 Yeah, fixes the issue :-) Thanks @emulienfou for fixing! |
|
ok tagged https://github.com/liip/LiipThemeBundle/releases/tag/1.6.1 would still be good to get a PR with a test case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relation issues: #194, #188 and PR #193