Twig deprecation notice #196
Conversation
|
thank you for this! I am a bit unsure about jumping to Twig 2.7 so quickly .. let me quickly collect some feedback via twitter |
For DoctrineBundle, we changed the constraint to also allow 1.x versions with namespaced classes: https://github.com/doctrine/DoctrineBundle/blob/90a7508c0da6b2c8add42f3f91020480f5d1ba2c/composer.json#L43 (twig is optional for DoctrineBundle, hence the combination of |
|
ok .. didn’t realize that Twig 1.34+ has namespaced aliases .. @emulienfou could you look into supporting that version as well? |
|
Hi @lsmith77 working on it as soon as possible |
|
@lsmith77 I previously drop support of PHP5.6 and SF2.7 too. |
|
yeah. that is fine
On Thu, 4 Apr 2019 at 18:53, David Sanchez ***@***.***> wrote:
@lsmith77 <https://github.com/lsmith77> I previously drop support of
PHP5.6 and SF2.7 too.
Is this OK for you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#196 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AASU90y6_DMLUwAWBadvUersqXhSNK3bks5vdi3ygaJpZM4cLoKb>
.
--
regards,
Lukas
|
|
@lsmith77 Do you think you can merge this PR and make a release? Thanks a lot @emulienfou ! |
|
thank you! waiting for some feedback before making a release https://twitter.com/lsmith/status/1130747016190017536 |
| @@ -13,13 +13,11 @@ cache: | |||
| - $HOME/.composer/cache/files | |||
|
|
|||
| env: | |||
| - SYMFONY_VERSION=2.7.* | |||
| - SYMFONY_VERSION=3.0.* | |||
There was a problem hiding this comment.
3.0.* does not make sense, as that's unmaintained. The default should be to not force a Symfony version. And then having some jobs forcing LTS versions
| env: TWIG_VERSION=2.x | ||
| - php: 5.6 | ||
| env: COMPOSER_FLAGS="--prefer-lowest" | ||
| env: TWIG_VERSION=2.7.* |
There was a problem hiding this comment.
why 2.7.* ? That will be unmaintained as soon as Twig 2.8 is released.
There was a problem hiding this comment.
I think the intention is to test the lower bound, but I guess then it should be 2.4
|
@emulienfou are you motivated to work on the suggested improvements from @stof to the build matrix ? |
This Pull Request fix all Twig deprecation notices when using Twig
>= 2.7who now use namespaces.However to achieve this, the support for SF2.7, PHP5.x and Twig < 2.7 has been dropped.