Fixing InvalidArgumentException with 'Cannot redirect to an empty URL'

[iakunin]

This exception occurs when 'Referer' header exists but empty.

In this case empty string goes to the first arg of \Symfony\Component\HttpFoundation\RedirectResponse constructor.

And then \InvalidArgumentException is thrown inside \Symfony\Component\HttpFoundation\RedirectResponse::setTargetUrl method.

[iakunin]

@lsmith77, could you give me some feedback, please?

[lsmith77]

makes sense .. could you also add a test case?

[iakunin]

@lsmith77,

I added unit-test for all cases came into my mind + also I covered the case when NotFoundHttpException is thrown.

But it's hard to cover the case with $cookieOptions, because of the time() function.

If you want, I can extract this time() function to separate TimeProvider and mock it.

---

Also I added SymfonyResponseComparator to prevent build from failure. It happened during comparison two Symfony-responses: their Date-headers are are different from each other. That's because new DateTime() during response creation. When the time between creation of two responses differs more than 1 sec, build fails.

SymfonyResponseComparator removes Date-header from the comparison of two responses.

[lsmith77]

nice!

SymfonyResponse might even be something for Symfony core ..?

for the call to time() .. it might be best to just switch to $request->server->get('REQUEST_TIME')

[lsmith77]

perfect!

[iakunin]

@lsmith77, thank you so much for your feedback!

May I ask you to create a new Release (1.6.2)?

[lsmith77]

I will make a release as soon as #200 is merged.

However the next release will be 1.7.0

[iakunin]

@lsmith77, great!

I'll be waiting for it =)

[lsmith77]

sorry for the delay https://github.com/liip/LiipThemeBundle/releases/tag/1.7.0

[iakunin]

@lsmith77, thank you so much!