Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option ShowDefault #10

Closed
wants to merge 5 commits into from
Closed

Add option ShowDefault #10

wants to merge 5 commits into from

Conversation

shumkovdenis
Copy link

If option ShowDefault, then field should show without "groups" tag.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 82.759% when pulling 77636c9 on shumkovdenis:master into 05500a8 on liip:master.

@coveralls
Copy link

coveralls commented May 18, 2018

Coverage Status

Coverage increased (+0.4%) to 82.759% when pulling f99648f on shumkovdenis:master into bb4d97c on liip:master.

@mweibel
Copy link
Collaborator

mweibel commented May 22, 2018

hi @shumkovdenis
Thanks for your contribution!

I think a feature like this makes sense, but I'm unsure about the implementation. Could you say something about your use case?
Also ShowDefault is not a great naming IMO. Maybe together with clarifying the use case we could find a better name.

@shumkovdenis
Copy link
Author

shumkovdenis commented May 22, 2018

There are many fields in my structure and I would not like to, for each field, specify a tag if this field is valid for all groups. And so you can add to the configuration options with which we specify that by default to show all the fields.

@mweibel
Copy link
Collaborator

mweibel commented Mar 8, 2019

Hi,
This conflicts now with current master. Sorry that it took me way too long to come back to you!
Anyway are you still in need of this feature?
Please add tests if you continue to do so. Also add godoc comments as well as a README update.

@masseelch
Copy link
Contributor

masseelch commented Mar 8, 2021

I can provide a PR that implements this on another way, if you are willing to merge it. This can be closes than too. Two years have passed since this was opened.

@mweibel
Copy link
Collaborator

mweibel commented Mar 9, 2021

closing. replaced by #29

@mweibel mweibel closed this Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants