Fix for array of interface implementations

[hwshadow]

I ran into what I think is a bug in sheriff. It doesn't seem to be able to handle arrays of interface implementations, I added code and a test case which appears to confirm this.

Regards

type InterfaceableBeta struct {
	Integer int    `json:"integer" groups:"safe"`
	Secret  string `json:"secret"`
}
type InterfaceableCharlie struct {
	Integer int    `json:"integer" groups:"safe"`
	Secret  string `json:"secret"`
}
type ArrayOfInterfaceable []CanHazInterface
type CanHazInterface interface {
}
type InterfacerAlpha struct {
	Plaintext     string               `json:"plaintext" groups:"safe"`
	Secret        string               `json:"secret"`
	Nested        InterfaceableBeta    `json:"nested" groups:"safe"`
	Interfaceable ArrayOfInterfaceable `json:"interfaceable" groups:"safe"`
}
	a := InterfacerAlpha{
		"I am plaintext",
		"I am a secret",
		InterfaceableBeta{
			100,
			"Still a secret",
		},
		ArrayOfInterfaceable{
			InterfaceableBeta{200, "Still a secret good"},
			InterfaceableCharlie{300, "Still a secret exellect"},
		}}

--- FAIL: TestMarshal_ArrayOfInterfaceable (0.00s)
	sheriff_test.go:459:
			Error Trace:	sheriff_test.go:459
			Error:      	Not equal:
			            	expected: "{\"interfaceable\":[{\"integer\":200},{\"integer\":300}],\"nested\":{\"integer\":100},\"plaintext\":\"I am plaintext\"}"
			            	actual  : "{\"interfaceable\":[{\"integer\":200,\"secret\":\"Still a secret good\"},{\"integer\":300,\"secret\":\"Still a secret exellect\"}],\"nested\":{\"integer\":100},\"plaintext\":\"I am plaintext\"}"

			            	Diff:
			            	--- Expected
			            	+++ Actual
			            	@@ -1 +1 @@
			            	-{"interfaceable":[{"integer":200},{"integer":300}],"nested":{"integer":100},"plaintext":"I am plaintext"}
			            	+{"interfaceable":[{"integer":200,"secret":"Still a secret good"},{"integer":300,"secret":"Still a secret exellect"}],"nested":{"integer":100},"plaintext":"I am plaintext"}
			Test:       	TestMarshal_ArrayOfInterfaceable

see c0b2fa2 for the struct that showcases the bug.

[coveralls]

Coverage remained the same at 82.353% when pulling 1502d8d on hwshadow:master into c385ca6 on liip:master.

[mweibel]

Thank you for the fix, that looks decent. Just a small nitpick but otherwise that's all fine.
I'll take care about the travis CI issues with older go versions afterwards.

[mweibel]

Thanks! that's merged in.

[hwshadow]

Not at problem, thanks for starting a great project!

…

On Thu, Dec 20, 2018, 2:12 AM Michael Weibel ***@***.*** wrote: Thanks! that's merged in. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#14 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AavUD9-uv0fzXc7Qip4SZVI_hLHkvrbiks5u62KLgaJpZM4Zba0C> .