Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marshals nil slices/arrays like expected and equivalent to json.marshal #40

Merged
merged 2 commits into from
May 9, 2023
Merged

marshals nil slices/arrays like expected and equivalent to json.marshal #40

merged 2 commits into from
May 9, 2023

Conversation

TorbenCK
Copy link
Contributor

@TorbenCK TorbenCK commented May 9, 2023

In comparison to json.Marshal sheriff converts nil arrays to empty arrays.

This Pull Request fixes the difference between json.Marshal and sheriff.Marshal

@coveralls
Copy link

Coverage Status

Coverage: 84.615% (+0.0%) from 84.615% when pulling f402553 on TorbenCK:master into cd01545 on liip:master.

@mweibel mweibel merged commit ecc6ca1 into liip:master May 9, 2023
This was referenced May 9, 2023
@mweibel
Copy link
Collaborator

mweibel commented May 9, 2023

scratch that - had to revert it - see #42 and give feedback please. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants