Fix for controllerAs syntax #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 19, 2015 06:45
Getting latest from master
Fix for controllerAs syntax for inline controller definitions. Named controllers still work as before as well.
Closed
|
@andrewogburn Thank you for the fix! Not nice that 2 last parameters for $controller are not documented on AngularJS website and considered private API's. |
egor-smirnov
added a commit
that referenced
this pull request
Jun 20, 2015
Fix for controllerAs syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for controllerAs syntax for inline controller definitions. Named controllers still work as before as well. This should fix the issue @djindjic is experiencing.