🚧 [WIP] Revamp metabox into admin settings #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamchong
force-pushed
the
develop
branch
2 times, most recently
from
5a61cd5 to
132cb1f
Compare
williamchong
changed the title
nnkken
reviewed
Aug 23, 2018
| const elem = document.querySelector(`.likecoin${selector}`); | ||
| elem.style.display = ''; | ||
| const elems = document.querySelectorAll(`.likecoin${selector}`); | ||
| elems.forEach((elem) => { elem.style.display = ''; }); // eslint-disable-line no-param-reassign |
There was a problem hiding this comment.
querySelectorAll is not returning an array, but a NodeList, see: https://developer.mozilla.org/en-US/docs/Web/API/NodeList/forEach#Browser_Compatibility
Do we need Array.prototype.forEach.call(elems, ...)?
There was a problem hiding this comment.
should we trust babel in this case
There was a problem hiding this comment.
zloirock/core-js#329 seems it doesn't polyfill itself, will handle later
nnkken
reviewed
Aug 23, 2018
likecoin/assets/js/likecoin.js
Outdated
| @@ -95,6 +92,7 @@ async function login() { | |||
| throw new Error(webThreeError); | |||
| } | |||
| const challenge = await fetchLikeCoinID(address); | |||
| console.log(challenge); | |||
🎨 shorten wallet in UI
🚸 Hide menu when cannot edit site likebutton setting
🎨 Show site LikeCoin ID in My LikeButton page if site button is enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated UI