-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(bug-fix): properly parse .dk domains #76
Conversation
Hello @eyJhb If you think this repository is helpful, please share it with friends, thanks. |
I didn't expect this to be merged that quickly :D - I have however just discovered an oversight on my part.
What would even be the proper field for that? Sorry for this however, that was not my intention ! I'm very glad for the quick merge, and this awesome project! |
Also, I'm unsure if the phone number should be parsed into phone and phoneext, e.g.
|
so, what is |
there is no necessary |
Sorry for not replying to you, holidays etc.
TL;DR: The attention is not really the email, but it's just.. a freetext field (maybe), but I'm not sure where it fits in, in the contact. If it even fits in. Do you have any suggestions for where to put attention? |
The examples in the repository, was some of the few domains in the entirety of Denmark, that didn't contain all the good information.
I've added folketinget.dk, which has a phone number example + names, etc. and politikken.dk, which has an email address as well.
Besides that, I've made a quick change in how the parser work, and made a special case for
.dk
domains.If this does not live up to the code standard, then please do inform me :)