Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[recnet-api] Add email retry #230

Merged
merged 3 commits into from
May 4, 2024
Merged

[recnet-api] Add email retry #230

merged 3 commits into from
May 4, 2024

Conversation

joannechen1223
Copy link
Collaborator

@joannechen1223 joannechen1223 commented May 3, 2024 •
edited
Loading

Description

Add email retry and set the retry limit to 3.

Related Issue

Notes

N/A

TODO

  • Paste the testing link
  • Clear console.log or console.error for debug usage
  • Update the documentation recnet-docs if needed
  • Version bump in package.json if needed

@vercel Vercel
Copy link

vercel bot commented May 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
rec-net ⬜️ Ignored (Inspect) Visit Preview May 4, 2024 4:15am
recnet-docs ⬜️ Ignored (Inspect) Visit Preview May 4, 2024 4:15am

@joannechen1223 joannechen1223 requested a review from swh00tw May 3, 2024 05:10
@joannechen1223 joannechen1223 self-assigned this May 3, 2024
swh00tw
swh00tw approved these changes May 4, 2024
View reviewed changes
Copy link
Collaborator

@swh00tw swh00tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: move the sleep time magic number to email.const.ts? so that we can adjust it easier if needed in the future.

@joannechen1223 joannechen1223 merged commit f66b12d into recnet-api-dev May 4, 2024
4 checks passed
@joannechen1223 joannechen1223 deleted the recnet-api/email-retry branch May 4, 2024 04:17
@joannechen1223 joannechen1223 mentioned this pull request May 5, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swh00tw swh00tw swh00tw approved these changes

Assignees

@joannechen1223 joannechen1223

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joannechen1223 @swh00tw