[recnet-api] Add new api endpoint: get single rec by id #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
joannechen1223
approved these changes
Sep 22, 2024
| @@ -12,6 +12,15 @@ import { getNextCutOff } from "@recnet/recnet-date-fns"; | |||
| export default class RecRepository { | |||
| constructor(private readonly prisma: PrismaConnectionProvider) {} | |||
|
|
|||
| public async findRecById(recId: string): Promise<Rec | null> { | |||
| return this.prisma.recommendation.findUnique({ | |||
There was a problem hiding this comment.
[nit] Maybe you can use findUniqueOrThrow if this is not a normal use case. But the error handling in recnet.exception.filter.ts should be modified a bit.
There was a problem hiding this comment.
I see. I originally use findUniqueOrThrow but when testing, the error code I saw was "2001" which is "User not found". I forget to modify recnet.exception.filter.ts. No wonder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new API endpoint
GET /recs/rec/:idRelated Issue
Notes
TODO
console.logorconsole.errorfor debug usagerecnet-docsif neededpackage.jsonif needed