[recnet-web] Display cycle in feeds page & consolidate date picker component #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
joannechen1223
approved these changes
Oct 9, 2024
swh00tw
added a commit
that referenced
this pull request
Oct 9, 2024
## RecNet auto-release action This is an auto-generated PR by recnet-release-action 🤖 Please make sure to test your changes in staging before merging. ## Related Issues - #60 - #324 - #317 - #253 - #254 ## Related PRs - #322 - #325 - #320 - #311 ## Staging links recnet-web: [https://vercel.live/link/recnet-git-dev-recnet-542617e7.vercel.app](https://vercel.live/link/recnet-git-dev-recnet-542617e7.vercel.app) recnet-api: [https://dev-api.recnet.io/api](https://dev-api.recnet.io/api)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR mainly address two issues
CutoffDatePickerand inDatePicker. This PR refactor the code duplication inCutoffDatePickerand extendDatePickerfunctionality./feedspage doesn't show the current cycle. When navigating to old cycles, it's hard to know which cycle we are viewing currently.Related Issue
/feedspage #253Notes
Test
The CutoffDatePicker should behave the same as in the past.
We could see a "current cycle" indicator in feeds page like this
TODO
console.logorconsole.errorfor debug usagerecnet-docsif neededpackage.jsonif needed