Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[recnet-web] Adjust og and metadata desc #343

Merged
merged 3 commits into from
Oct 28, 2024
Merged

[recnet-web] Adjust og and metadata desc #343

merged 3 commits into from
Oct 28, 2024

Conversation

swh00tw
Copy link
Collaborator

@swh00tw swh00tw commented Oct 26, 2024 •
edited
Loading

Description

  • Increase OG image size
  • Fix rec page metadata desc

Related Issue

Notes

Test

  • OG image size should be bigger (This is a little bit hard to test, sometimes it works in slack, sometimes it doesn't. I am guessing maybe it's related to slack's cache. But even if I cleared cache, still unstable. Anyway, I can confirm it's def bigger by inspecting in html . The size is correct in below image)

Screenshot 2024-10-25 at 11 30 22 PM

  • Rec page's desc should be "{username} recommends: ${desc}"

Screenshots (if appropriate):

TODO

  • Clear console.log or console.error for debug usage
  • Update the documentation recnet-docs if needed

@vercel Vercel
Copy link

vercel bot commented Oct 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
recnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2024 3:11am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
recnet-docs ⬜️ Ignored (Inspect) Oct 26, 2024 3:11am

@swh00tw swh00tw changed the title Fix/og and metadata desc [recnet-web] Adjust og and metadata desc Oct 26, 2024
@swh00tw swh00tw merged commit 7e59be4 into dev Oct 28, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Oct 28, 2024
Merged
swh00tw added a commit that referenced this pull request Oct 29, 2024
@swh00tw
Release dev to master (#345)
399f7cb 
## RecNet auto-release action
This is an auto-generated PR by recnet-release-action 🤖
Please make sure to test your changes in staging before merging. 
## Related Issues
- #341
- #335
- #301
- #260
- #261
- #342
## Related PRs
- #346
- #344
- #343
## Staging links
recnet-web:
[https://vercel.live/link/recnet-git-dev-recnet-542617e7.vercel.app](https://vercel.live/link/recnet-git-dev-recnet-542617e7.vercel.app)
recnet-api:
[https://dev-api.recnet.io/api](https://dev-api.recnet.io/api)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joannechen1223 joannechen1223 joannechen1223 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swh00tw @joannechen1223