Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release dev to master recnet-api v1.8.3 / recnet v1.16.2 #360

Merged
merged 16 commits into from
Nov 19, 2024
Merged

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Nov 18, 2024

joannechen1223 and others added 12 commits November 12, 2024 10:54
## Description

<!--- Describe your changes in detail -->
Redesign rec page og style

## Related Issue

<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an
issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps
to reproduce -->
<!--- Please link to the issue here: -->

- #355 

## Notes

<!-- Other thing to say -->

## Test

<!--- Please describe in detail how you tested your changes locally. -->

## Screenshots (if appropriate):

<!--- Add screenshots of your changes here -->

Before:
![Screenshot 2024-11-14 at 4 12
56 PM](https://github.com/user-attachments/assets/198dc1a6-0f13-4b84-8e82-dab4085649f3)

It looks like this now

![Screenshot 2024-11-14 at 4 11
59 PM](https://github.com/user-attachments/assets/2c29fe42-b517-470e-9933-80fc98b77ba9)


## TODO

- [ ] Clear `console.log` or `console.error` for debug usage
- [ ] Update the documentation `recnet-docs` if needed
Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
recnet ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 2:27pm
recnet-docs ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 2:27pm

## Description

Follow the person who invites the user when creating an account

## Related Issue

- #356

## Notes

<!-- Other thing to say -->
N/A

## Test

1. Run local server
2. Create a user by hitting `POST /users/me`
3. Check if there is a following record that followerId = userId and
followingId = inviterId

## Screenshots (if appropriate):

TBA

## TODO

- [x] Clear `console.log` or `console.error` for debug usage
- [ ] Update the documentation `recnet-docs` if needed
## Description

<!--- Describe your changes in detail -->
Beautify slack weekly digest template

## Related Issue

<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an
issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps
to reproduce -->
<!--- Please link to the issue here: -->

- #261 
- #64 

## Notes

<!-- Other thing to say -->
Misc: I think we should add email and slack testing API endpoints back
to ease the development, but I am not sure where to add it, maybe create
`subscription.controller.ts` again? @joannechen1223

## Test

<!--- Please describe in detail how you tested your changes locally. -->

You will need to add back the `POST /subsriptions/slack/test` endpoint
to test. I will provide example code below in the comment to show how I
use mock data to test it.

## Screenshots (if appropriate):

<!--- Add screenshots of your changes here -->
The data in the screenshot were generated by `generateMock()`.

![Screenshot 2024-11-16 at 11 43
14 PM](https://github.com/user-attachments/assets/0077fe9e-03bf-462f-98e0-e1126c35d462)

## TODO

- [ ] Clear `console.log` or `console.error` for debug usage
- [ ] Update the documentation `recnet-docs` if needed
@github-actions github-actions bot requested a review from swh00tw November 19, 2024 14:26
@joannechen1223 joannechen1223 changed the title Release dev to master Release dev to master recnet-api v1.8.3 / recnet v1.16.2 Nov 19, 2024
@joannechen1223 joannechen1223 merged commit 9965a1f into master Nov 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants