Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[recnet-web] RecNet Slack OAuth Flow #361

Merged
merged 16 commits into from
Dec 2, 2024
Merged

[recnet-web] RecNet Slack OAuth Flow #361

merged 16 commits into from
Dec 2, 2024

Conversation

swh00tw
Copy link
Collaborator

@swh00tw swh00tw commented Nov 21, 2024

Description

Finish slack oauth flow.

Related Issue

Notes

Test

Before test, update .env.local

  • NEXT_PUBLIC_BASE_URL should be https://localhost:3000
  • Add SLACK_APP_CLIENT_ID
  • Add SLACK_OAUTH_APP_SCOPES
  • AddSLACK_OAUTH_REDIRECT_URI="/api/slack/oauth/callback"

Run nx dev:ssl recnet and go to https://localhost:3000

  • Go to setting and subscription tab -> Click the button to install slack app to your workspace
  • Should redirect you to slack page
  • Should able to choose different workspace
  • After clicking "Allow", should redirect back to frontend and see the success message
  • Go to setting again, should see the workspace name of where you install the app

Screenshots (if appropriate):

Screenshot 2024-11-21 at 5 59 40 PM
Screenshot 2024-11-21 at 5 59 50 PM
Screenshot 2024-11-21 at 6 00 07 PM

TODO

  • Clear console.log or console.error for debug usage
  • Update the documentation recnet-docs if needed

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
recnet ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 10:18pm
recnet-docs ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 10:18pm

@swh00tw swh00tw force-pushed the feat/fe-slack-oauth branch from 9208d32 to 4fcf84d Compare November 26, 2024 00:46
Copy link
Collaborator

@joannechen1223 joannechen1223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my end and can go through the whole process successfully. Thanks for your hard work!
The only concern I have here is that when a user clicks "remove" after the slack app was installed in the designated workspace, the settings panel shows it is removed, but actually it was not. The removal only means disconnecting the slack app from our system, and the slack app will still be there. Users will need to go to the slack app management to uninstall it. This is kind of confusing. However, I know that it's hard to help users uninstall from our platform, but maybe some tweets of the wording would make the user experience better imo.

@swh00tw
Copy link
Collaborator Author

swh00tw commented Dec 2, 2024

Tested on my end and can go through the whole process successfully. Thanks for your hard work! The only concern I have here is that when a user clicks "remove" after the slack app was installed in the designated workspace, the settings panel shows it is removed, but actually it was not. The removal only means disconnecting the slack app from our system, and the slack app will still be there. Users will need to go to the slack app management to uninstall it. This is kind of confusing. However, I know that it's hard to help users uninstall from our platform, but maybe some tweets of the wording would make the user experience better imo.

Rephrased to make it less confusing.

@swh00tw swh00tw merged commit 461a3ba into dev Dec 2, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Dec 2, 2024
joannechen1223 added a commit that referenced this pull request Dec 3, 2024
## RecNet auto-release action
This is an auto-generated PR by recnet-release-action 🤖
Please make sure to test your changes in staging before merging. 
## Related Issues
- #261
- #64
## Related PRs
- #369
- #361
- #365
- #364
- #362
## Staging links
recnet-web:
[https://vercel.live/link/recnet-git-dev-recnet-542617e7.vercel.app](https://vercel.live/link/recnet-git-dev-recnet-542617e7.vercel.app)
recnet-api:
[https://dev-api.recnet.io/api](https://dev-api.recnet.io/api)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants