-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[recnet-web] RecNet Slack OAuth Flow #361
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
9208d32
to
4fcf84d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on my end and can go through the whole process successfully. Thanks for your hard work!
The only concern I have here is that when a user clicks "remove" after the slack app was installed in the designated workspace, the settings panel shows it is removed, but actually it was not. The removal only means disconnecting the slack app from our system, and the slack app will still be there. Users will need to go to the slack app management to uninstall it. This is kind of confusing. However, I know that it's hard to help users uninstall from our platform, but maybe some tweets of the wording would make the user experience better imo.
Rephrased to make it less confusing. |
## RecNet auto-release action This is an auto-generated PR by recnet-release-action 🤖 Please make sure to test your changes in staging before merging. ## Related Issues - #261 - #64 ## Related PRs - #369 - #361 - #365 - #364 - #362 ## Staging links recnet-web: [https://vercel.live/link/recnet-git-dev-recnet-542617e7.vercel.app](https://vercel.live/link/recnet-git-dev-recnet-542617e7.vercel.app) recnet-api: [https://dev-api.recnet.io/api](https://dev-api.recnet.io/api)
Description
Finish slack oauth flow.
Related Issue
Notes
Test
Before test, update
.env.local
NEXT_PUBLIC_BASE_URL
should behttps://localhost:3000
SLACK_APP_CLIENT_ID
SLACK_OAUTH_APP_SCOPES
SLACK_OAUTH_REDIRECT_URI="/api/slack/oauth/callback"
Run
nx dev:ssl recnet
and go tohttps://localhost:3000
Screenshots (if appropriate):
TODO
console.log
orconsole.error
for debug usagerecnet-docs
if needed